Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remover atributos de request do método APIResource::createAPI #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

erickmcarvalho
Copy link

Sugiro a remoção dos atibutos da requisição no método APIResource::createAPI, pois os atributos causam override na resposta da API, o que pode levar em perda de dados da resposta.

Exemplo:

Atributo da lista de itens na requisição:

[
    'description' => 'Produto Teste',
    'price_cents' => 100,
    'quantity' => 1
]

Como a resposta vem da API:

[
    'id' => '11DA8B1662EC4C30BC4C78AEDC619145',
    'description' => 'Produto Teste',
    'price_cents' => 100,
    'quantity' => 1,
    'created_at' => '2014-06-17T09:58:05-03:00',
    'updated_at' => '2014-06-17T09:58:05-03:00',
    'price' => 'R$ 10,00'
]

Porém, ao aplicar o código

foreach ($attributes as $attr => $value) {
    $response[$attr] = $value;
}

Basicamente causa override pelas chaves de request e response serem as mesmas, e com isso você perde dados da resposta.
Não há necessidade alguma de incluir os atributos de request na resposta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant